You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It will not consider PostgreSQL installations running on another port like 5433 (this will make PostgreSQL create a unix socket called .s.PGSQL.5433 and not .s.PGSQL.5432), so it will fail to connect. This can cause some annoyances on PostgreSQL cluster installations where you can run more than one PostgreSQL version and server on different ports (how Debian seems to handle it: https://wiki.debian.org/PostgreSql#Listing_existing_database_clusters).
This is not a problem when using database_url since you can pass a custom unix socket path using the host query parameter like this:
It will not consider PostgreSQL installations running on another port like 5433 (this will make PostgreSQL create a unix socket called .s.PGSQL.5433 and not .s.PGSQL.5432), so it will fail to connect.
I think that all we need to do is adapt our code to not build a postgres:// URI if we see a host starting with /.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
need-testingThis feature needs to be deployed and tested to see if it's working, and doesn't break something
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently only
database_urlshows how to connect via unix sockets. This adds some docs fordbtoo